fix: install package.xml to support ros2 doctor (#125)#130
Open
AKG451 wants to merge 1 commit intoopen-rmf:mainfrom
Open
fix: install package.xml to support ros2 doctor (#125)#130AKG451 wants to merge 1 commit intoopen-rmf:mainfrom
AKG451 wants to merge 1 commit intoopen-rmf:mainfrom
Conversation
1 task
Signed-off-by: AKG451 <akg451154@gmail.com>
AKG451
force-pushed
the
fix-package-xml-clean
branch
from
086fc3a to
eec20e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #125
Summary: Added install(FILES package.xml ...) to rmf_traffic/CMakeLists.txt. This allows ros2 doctor and ros2 pkg to identify the package version while maintaining the "pure CMake" nature of the library.
Validation: Verified locally that ros2 pkg xml rmf_traffic now returns the correct metadata.