Merged
Conversation
Contributor
Author
|
The checks are really failing but probably not set to be needed to merge? |
Contributor
Author
|
Not sure if it ever worked or if it's failing with the same error now as 3 months ago: |
Contributor
|
Looks like it's just style complaints: |
Signed-off-by: Esteban Martinena <orensbruli@gmail.com>
531dd70 to
94a50fe
Compare
Contributor
Author
Fixed those but it looks like for focal ones it's the same problem we found here: open-rmf/rmf#202 (comment) We could try to go with any of the two options suggested here and wait (open-rmf/rmf#202 (comment)) or I could avoid the workflow to run in focal-based distros. What do you think? |
This was referenced Dec 7, 2022
Closed
Signed-off-by: Esteban Martinena <orensbruli@gmail.com>
39ddcea to
26f642a
Compare
Signed-off-by: Esteban Martinena <orensbruli@gmail.com>
Signed-off-by: Esteban Martinena <orensbruli@gmail.com>
Signed-off-by: Esteban Martinena <orensbruli@gmail.com>
Signed-off-by: Esteban Martinena <orensbruli@gmail.com>
26f642a to
5dcd92d
Compare
marcoag
approved these changes
Dec 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified build.yaml to use reusable workflow.
Signed-off-by: Esteban Martinena orensbruli@gmail.com