Skip to content

[CI] Removed push event from workflows #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
orensbruli wants to merge 3 commits into from
Closed

[CI] Removed push event from workflows #25

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d0bfe4
[CI] Removed push event from workflows
orensbruli Sep 21, 2022
b8eb0dc
Add "push" on main to the triggers of the build action
orensbruli Dec 8, 2022
6548b27
Bump version of ros-tooling/setup-ros action
orensbruli Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
name: build
on:
Copy link
Copy Markdown
Member

@marcoag marcoag Dec 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we wanna run the workflow when a merge happens? I'm not sure if the pull_request will run it at merge time, if it doesn't maybe we wanna keep something like this?

Suggested change
on:
on:
push:
branches:
- master

push:
pull_request:
push:
branches:
- main
schedule:
- cron: '35 0 * * *'

Expand All @@ -15,7 +17,7 @@ jobs:
- name: pwd
run: pwd
- name: deps
uses: ros-tooling/setup-ros@v0.2
uses: ros-tooling/setup-ros@v0.4
with:
required-ros-distributions: rolling
- name: build
Expand Down