Skip to content

fix auth bypass #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arjo129 merged 2 commits into from
Mar 7, 2025
Merged

fix auth bypass #79

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7505783
fix auth bypass
koonpeng Mar 7, 2025
2bfa44b
close connection on auth fail
koonpeng Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions rmf_visualization_schedule/src/rmf_visualization_schedule/TrajectoryServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,6 @@ auto TrajectoryServer::Implementation::on_message(
return;
}

bool ok = parse_request(hdl, msg, response);

// validate jwt only if public key is given (when running with dashboard)
std::string public_key;
std::string token;
Expand All @@ -137,14 +135,18 @@ auto TrajectoryServer::Implementation::on_message(
}
catch (std::exception& e)
{
is_verified = false;
std::string err_excp = e.what();
send_error_message(hdl, msg, err_response, server, err_excp);
std::cerr << "Error: " << e.what() << std::endl;
server->close(hdl, websocketpp::close::status::normal,
"invalid auth token");
return;
}
}

if (ok && is_verified)
bool ok = parse_request(hdl, msg, response);

if (ok)
{
RCLCPP_DEBUG(schedule_data_node->get_logger(),
"Response: %s", response.c_str());
Expand Down