Skip to content

feat(nodejs): remove non-generic instrumentations from defaults #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wpessers wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(nodejs): remove non-generic instrumentations from defaults #1734

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
afab580
Remove non-generic instrumentations from the default instrumentation …
wpessers Mar 4, 2025
1ad32c1
fix formatting and typo
wpessers Dec 4, 2025
8595942
Merge branch 'main' into feat/nodejs/update-auto-instrumentation-defa…
maxday Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 3 additions & 17 deletions nodejs/packages/layer/src/wrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,21 +47,7 @@ import {
import { AWSXRayPropagator } from '@opentelemetry/propagator-aws-xray';
import { AWSXRayLambdaPropagator } from '@opentelemetry/propagator-aws-xray-lambda';

const defaultInstrumentationList = [
'dns',
'express',
'graphql',
'grpc',
'hapi',
'http',
'ioredis',
'koa',
'mongodb',
'mysql',
'net',
'pg',
'redis',
];
const defaultInstrumentationList = ['dns', 'http', 'net'];

const propagatorMap = new Map<string, () => TextMapPropagator>([
['tracecontext', () => new W3CTraceContextPropagator()],
Expand Down Expand Up @@ -103,7 +89,7 @@ declare global {
function configureLoggerProvider(loggerProvider: unknown): void;
}

function getActiveInstumentations(): Set<string> {
function getActiveInstrumentations(): Set<string> {
let enabledInstrumentations: string[] = defaultInstrumentationList;
if (process.env.OTEL_NODE_ENABLED_INSTRUMENTATIONS) {
enabledInstrumentations =
Expand All @@ -124,7 +110,7 @@ function getActiveInstumentations(): Set<string> {

async function defaultConfigureInstrumentations() {
const instrumentations = [];
const activeInstrumentations = getActiveInstumentations();
const activeInstrumentations = getActiveInstrumentations();
if (activeInstrumentations.has('amqplib')) {
const { AmqplibInstrumentation } = await import(
'@opentelemetry/instrumentation-amqplib'
Expand Down