Tolerate unknown properties in resolved schema / published manifest#1365
Open
lmolkova wants to merge 6 commits intoopen-telemetry:mainfrom
Open
Tolerate unknown properties in resolved schema / published manifest#1365lmolkova wants to merge 6 commits intoopen-telemetry:mainfrom
lmolkova wants to merge 6 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1365 +/- ##
=======================================
+ Coverage 82.2% 82.4% +0.2%
=======================================
Files 125 127 +2
Lines 10225 10325 +100
=======================================
+ Hits 8405 8509 +104
+ Misses 1820 1816 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lmolkova
force-pushed
the
tolerate-future
branch
from
284b5b6 to
21a7ed2
Compare
…ma and publication manifest
lmolkova
force-pushed
the
tolerate-future
branch
from
3bf2a65 to
b1b19d2
Compare
jsuereth
reviewed
Apr 29, 2026
| /// | ||
| /// Serializes and deserializes as the string form (e.g. `"resolved/2.0"`). | ||
| #[derive(Clone, PartialEq, Eq, Hash)] | ||
| pub struct FileFormat { |
Contributor
There was a problem hiding this comment.
@lmolkova I approve of most of this PR - but wanted to check in on your plans based on the discussion today.
I'm fine leaving this here with some flexibility we discussed, or addressing file-format expansion in a later PR.
Should I approve this PR as-is?
Member
Author
There was a problem hiding this comment.
this PR does not touch anything related to definition, I was going to address it in separate PR (within this release). So I think this one can go as is
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older weaver can now read files written by a newer minor version.
Warning
It introduces regression for definition side (we reuse quite a few types between definition and resolved).
Since deny_unknown_fields is relaxed, we'll tolerate errors in definitions that we failed on before.
Definitions PR: #1422