Merged
Conversation
Make ExpediterTask compatible with the configuration cache by dropping Task.project access at execution time and by replacing the mutable ArtifactCollection list fields with a ConfigurableFileCollection for tracked inputs plus a ListProperty<ClassfileSource> derived lazily via a Provider. Bump testkit-plugin to 0.0.18 for the InstrumentWithJacocoOfflineTask CC fix (0.0.17's publish workflow failed; 0.0.18 is the re-release), and work around a remaining latent CC bug in testkit's publishOnlyIf by replacing its onlyIf spec in the root build. Turn on configuration-cache in the project's gradle.properties and in each testkit integration test project so the plugin is exercised under CC end-to-end. Generated with Claude Code
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
=========================================
Coverage 90.94% 90.94%
+ Complexity 340 337 -3
=========================================
Files 44 44
Lines 1137 1137
Branches 157 157
=========================================
Hits 1034 1034
Misses 52 52
Partials 51 51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExpediterTaskconfiguration-cache compatible:report→RegularFileProperty, new@Input projectName: Property<String>(replacesproject.nameaccess at execution time), and the mutableList<ArtifactCollection>fields are replaced by aConfigurableFileCollectionfor tracked inputs plus aListProperty<ClassfileSource>populated lazily via a newArtifactCollection.toClassfileSources()provider helper.testkit-pluginto 0.0.18 for theInstrumentWithJacocoOfflineTaskconfig-cache fix from testkit-plugins#42 (0.0.17's publish workflow failed; 0.0.18 is the re-release). Add a root-project workaround for a latent CC bug in testkit'spublishOnlyIf— its predicate readsPublishToMavenRepository.publicationat execution time, which Gradle discards under CC; we replace theonlyIfspec with one derived from the task name.org.gradle.configuration-cache=truein the projectgradle.propertiesand add the same to eachplugin/src/test/projects/ExpediterPluginIntegrationTest/*fixture so the plugin is exercised under CC end-to-end.Test plan
./gradlew buildpasses withConfiguration cache entry storedon first run andConfiguration cache entry reusedon the next../gradlew :plugin:testpasses all 44 integration tests with CC enabled in both the outer build and the fixtures (JDK 21 — older Gradle versions in the test matrix don't support JDK 25).🤖 Generated with Claude Code