Implement lazy message conversion for protovalidate#402
Draft
andrewparmet wants to merge 9 commits intoopen-toast:mainfrom
Draft
Implement lazy message conversion for protovalidate#402andrewparmet wants to merge 9 commits intoopen-toast:mainfrom
andrewparmet wants to merge 9 commits intoopen-toast:mainfrom
Conversation
…tovalidate - Replace PackageHacks.kt / ProtoktEvaluator / ProtoktEvaluatorBuilder with direct use of protovalidate-java's new public validate(MessageReflector, Descriptor) entrypoint. - ProtoktMessageReflector implements MessageReflector; ProtoktObjectValue implements Value. Both live in the public protokt.v1.buf.validate package. - Validator.validate(message) looks up the descriptor by @GeneratedMessage's fullTypeName. - Make RuntimeContext incremental: descriptor registry is a PersistentMap and a new operator plus(descriptor) returns a copy with the descriptor registered. Avoids O(N²) rebuild when loading descriptors one at a time. - protokt-reflect now depends on kotlinx-collections-immutable. - Wire mavenLocal into the Java project convention so the protovalidate-java SNAPSHOT resolves during local development.
# Conflicts: # gradle/libs.versions.toml # protokt-protovalidate/src/main/kotlin/build/buf/protovalidate/PackageHacks.kt # protokt-protovalidate/src/main/kotlin/protokt/v1/buf/validate/Validator.kt # testing/protovalidate-conformance/build.gradle.kts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run conformance tests using the existing eager implementation with:
and the new lazy implementation with: