Drop -Preckon.stage=final from release workflow#48
Merged
Conversation
The flag was added in #46 as defense-in-depth against reckon's clean check failing, but it also disables the rebuild branch in Reckoner.reckonTargetVersion. With stage set, reckon skips the "isClean() && currentVersion.isPresent() && stage == null" path that returns the tag's exact version and instead computes a target normal via defaultInferredScope=patch, bumping 0.1.0 -> 0.1.1. That's why the 0.1.0 tag published as 0.1.1 to Maven Central. The .kotlin -> .gitignore change from #46 is the actual fix for the untracked-file clean-check problem. With that in place, the rebuild branch returns the tagged version cleanly and the flag is no longer needed. Verified locally at tag 0.1.0 with a clean tree: Reckoned version: 0.1.0 Generated with Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.1.0published as0.1.1to Maven Central because the release workflow passed-Preckon.stage=final.stageset, reckon skips the rebuild branch inReckoner.reckonTargetVersionthat would return the tag's exact version whenisClean() && currentVersion.isPresent() && stage == null, and instead computes a target normal viadefaultInferredScope=patch— bumping0.1.0to0.1.1..kotlin→.gitignorechange from Fix release workflow: ignore .kotlin and set reckon.stage=final #46 is the real fix for the untracked-file clean-check problem; the-Preckon.stage=final"defense in depth" is counterproductive.Verification
At tag
0.1.0with a clean tree:With
-Preckon.stage=final(the bug):Test plan
0.1.0(or cut a new tag) and confirm the release workflow publishes the tagged version, not tag+1.🤖 Generated with Claude Code