revert(ios): restore full xcscheme build configuration#1994
Closed
therajanmaurya wants to merge 2 commits intoopenMF:developmentfrom
Closed
revert(ios): restore full xcscheme build configuration#1994therajanmaurya wants to merge 2 commits intoopenMF:developmentfrom
therajanmaurya wants to merge 2 commits intoopenMF:developmentfrom
Conversation
📝 WalkthroughWalkthroughAn Xcode scheme configuration file is simplified by reducing the version number, removing optional test, profile, analyze, and archive actions, streamlining build flags, and consolidating launch action settings into a lean run-only configuration. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Reverts commit 97677fe which simplified the xcscheme too aggressively, removing essential build actions needed for iOS builds. Restored: - Schema version 1.7 (was 1.3) - parallelizeBuildables and buildImplicitDependencies flags - buildForTesting, buildForProfiling, buildForArchiving, buildForAnalyzing - TestAction, ProfileAction, AnalyzeAction, ArchiveAction sections - Full debugger configuration (LLDB) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
79c211f to
700ab06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the xcscheme simplification that broke iOS builds.
Changes
parallelizeBuildablesandbuildImplicitDependenciesflagsbuildForTesting,buildForProfiling,buildForArchiving,buildForAnalyzingTestAction,ProfileAction,AnalyzeAction,ArchiveActionsectionsTest Plan
🤖 Generated with Claude Code