-
Notifications
You must be signed in to change notification settings - Fork 6
Schemas for a more fine-grained representation of services #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c13db3d
Schemas for a more fine-grained representation of services (digital o…
apdavison a813eda
update following discussion with @lzehl
apdavison 0bbe657
Updates to match v0.4 of the specification document
apdavison e370a3f
Update deployedInterface.schema.tpl.json
lzehl 8ca07df
Update serviceDeployment.schema.tpl.json
lzehl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| { | ||
| "_type": "computation:DeployedInterface", | ||
| "required": [ | ||
| "accessibility", | ||
| "interface", | ||
| "location" | ||
| ], | ||
| "properties": { | ||
| "accessibility": { | ||
| "_instruction": "Add the accessibility of this deployed interface.", | ||
| "_linkedTypes": [ | ||
| "core:Accessibility" | ||
| ] | ||
| }, | ||
| "interface": { | ||
| "_instruction": "Enter the interface version that is deployed.", | ||
| "_linkedTypes": [ | ||
| "core:InterfaceVersion" | ||
| ] | ||
| }, | ||
| "location": { | ||
| "_instruction": "Add the location (for physical services) or URL (for digital services) where this deployed interface may be accessed.", | ||
| "_linkedTypes": [ | ||
| "core:Location", | ||
| "core:WebResource" | ||
| ] | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| { | ||
| "_type": "computation:ServiceDeployment", | ||
| "required": [ | ||
| "name", | ||
| "provides", | ||
| "service", | ||
| "startTime" | ||
| ], | ||
| "properties": { | ||
| "dependsOn": { | ||
| "_instruction": "Add the software version and any other relevant research product version that was deployed.", | ||
| "type": "array", | ||
| "minItems": 1, | ||
| "uniqueItems": true, | ||
| "_linkedTypes": [ | ||
|
lzehl marked this conversation as resolved.
|
||
| "computation:WorkflowRecipeVersion", | ||
| "core:DatasetVersion", | ||
| "core:MetaDataModelVersion", | ||
| "core:ModelVersion", | ||
| "core:SoftwareVersion", | ||
| "sands:AnatomicalAtlasVersion", | ||
| "sands:CommonCoordinateFrameworkVersion" | ||
| ] | ||
| }, | ||
| "deploymentType": { | ||
| "_instruction": "Enter the type of deployment environment, for example, 'production' or 'integration'.", | ||
| "_linkedTypes": [ | ||
| "controlledTerms:DeploymentEnvironmentType" | ||
| ] | ||
| }, | ||
| "endTime": { | ||
| "type": "string", | ||
| "_formats": [ | ||
| "datetime" | ||
| ], | ||
| "_instruction": "Enter the date and time at which this deployment ended, formatted acoording to ISO-8601." | ||
| }, | ||
| "name": { | ||
| "type": "string", | ||
| "_instruction": "Enter a label for this service deployment." | ||
| }, | ||
| "provides": { | ||
| "_instruction": "Add the interfaces that have been deployed.", | ||
| "type": "array", | ||
| "minItems": 1, | ||
| "uniqueItems": true, | ||
| "_embeddedTypes": [ | ||
| "computation:DeployedInterface" | ||
| ] | ||
| }, | ||
| "service": { | ||
| "_instruction": "Add the service that has been deployed.", | ||
| "_linkedTypes": [ | ||
| "core:Service" | ||
| ] | ||
| }, | ||
| "startTime": { | ||
| "type": "string", | ||
| "_formats": [ | ||
| "datetime" | ||
| ], | ||
| "_instruction": "Enter the date and time at which this deployment was started, formatted acoording to ISO-8601." | ||
| }, | ||
| "uses": { | ||
| "_instruction": "Add the deployed interfaces and any other relevant research product versions that are used by this deployment.", | ||
| "type": "array", | ||
| "minItems": 1, | ||
| "uniqueItems": true, | ||
| "_linkedTypes": [ | ||
|
lzehl marked this conversation as resolved.
|
||
| "computation:WorkflowRecipeVersion", | ||
| "computation:DeployedInterface", | ||
| "core:DatasetVersion", | ||
| "core:MetaDataModelVersion", | ||
| "core:ModelVersion", | ||
| "sands:AnatomicalAtlasVersion", | ||
| "sands:CommonCoordinateFrameworkVersion" | ||
| ] | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we don't want to call this service deployment but rather deployment only? and also making the service optional? or did we say now everything with an interface is a service?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hasPart for implemented configurations need to be covered in here: CommonCoordinateFrameworkVersion, AnatomicalAtlasVersion, ModelVersion (maybe include also LaunchConfiguration?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now solved through dependsOn and uses