Skip to content

Add kiloohm unit of measurement#469

Open
ree-gupta wants to merge 1 commit intomainfrom
add-kiloohm-unit
Open

Add kiloohm unit of measurement#469
ree-gupta wants to merge 1 commit intomainfrom
add-kiloohm-unit

Conversation

@ree-gupta
Copy link
Copy Markdown

Add kiloohm (kΩ) to the unitOfMeasurement terminology for the NHP-EBRAINS dataset use case.

Closes #468

@ree-gupta
Copy link
Copy Markdown
Author

Hi @Raphael-Gazzotti The contributing guidelines recommended creating an issue and then a PR so I did that. In general, do you recommend that I batch all the instances I need and will need into a single issue and corresponding PR?

@ree-gupta
Copy link
Copy Markdown
Author

I didn't add a definition since the other derived units (megaohm, gigaohm) don't have one - only ohm does. Should I add one?

@Raphael-Gazzotti
Copy link
Copy Markdown
Member

@ree-gupta Proceeding with batches of instances can be an option when they belong to the same type. That said, for reviewability, it’s generally preferable to split larger changes into multiple PRs when many instances are added or modified.

You can also add definitions where possible, we aim to have at least one definition for all controlled terms. The missing ones are mostly associated with older instances.

@Raphael-Gazzotti Raphael-Gazzotti added the request any request or update for instances that are not covered by Technique, ContentType or SANDS label label Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

request any request or update for instances that are not covered by Technique, ContentType or SANDS label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add kiloohm unit of measurement

2 participants