Conversation
…ion_vnd.spike2-32.sonpy.son.jsonld
|
@JuliaSprenger is also very welcome to review this PR and give feedback. I hope that I migrated everything correctly. |
lzehl
left a comment
There was a problem hiding this comment.
I would also like to have a one sentence description for each. @apdavison I think we should discuss those in detail.
| ".lsx", | ||
| ".mpx" | ||
| ], | ||
| "name": "application/vnd.alphaomega.v0-eng", |
There was a problem hiding this comment.
| "name": "application/vnd.alphaomega.v0-eng", | |
| "name": "application/vnd.alphaomega-eng.v0", |
if -eng belongs to the company name and v0 points to the version it should be this way around, no? @apdavison
| "synonym": [ | ||
| "MaxOne HDF5", | ||
| "MaxTwo HDF5" | ||
| ] |
There was a problem hiding this comment.
this is a bit weird, MaxOne and MaxTwo are different MEA systems. If they are using the same file format the synonym of the file format should not be combined with the system name (unless this is what they officially do). I would suggest calling this MaxWell HDF5, or MaxWell Biosystems HDF5
| "dataType": null, | ||
| "description": null, | ||
| "displayLabel": null, | ||
| "fileExtension": null, |
There was a problem hiding this comment.
No extension? is this not a content type for files but for bundles?
| "dataType": null, | ||
| "description": null, | ||
| "displayLabel": null, | ||
| "fileExtension": null, |
There was a problem hiding this comment.
no extensions? is this for bundles not for files?
| "@id": "https://openminds.om-i.org/instances/contentTypes/application_vnd.numpy.multiarray", | ||
| "@type": "https://openminds.om-i.org/types/ContentType", | ||
| "dataType": null, | ||
| "description": "File format by numpy that provides storage of array data using gzip compression.", |
There was a problem hiding this comment.
| "description": "File format by numpy that provides storage of array data using gzip compression.", | |
| "description": "A compressed archive format used by NumPy to store a collection of individual NumPy arrays (.npy files) in a single zip archive file.", |
| "fileExtension": [ | ||
| ".npz" | ||
| ], | ||
| "name": "application/vnd.numpy.multiarray", |
There was a problem hiding this comment.
@apdavison should this be ?
| "name": "application/vnd.numpy.multiarray", | |
| "name": "application/vnd.numpy.multiarray+zip", |
| "description": null, | ||
| "displayLabel": null, | ||
| "fileExtension": null, | ||
| "fileExtension": [ |
There was a problem hiding this comment.
is this really one content type? or rather different ones?
| "fileExtension": [ | ||
| ".smr" | ||
| ], | ||
| "name": "application/vnd.spike2-32.sonpy.son", |
There was a problem hiding this comment.
| "name": "application/vnd.spike2-32.sonpy.son", | |
| "name": "application/vnd.spike2.sonpy-binary32", |
what was the .son for?
we need to define a convention of bitness for our content types
| "fileExtension": [ | ||
| ".smrx" | ||
| ], | ||
| "name": "application/vnd.spike2-64.sonpy.son", |
There was a problem hiding this comment.
convention for bitness should be different I think (see spike2-32)
|
@apdavison @UlrikeS91 it seems that all content types from this PR are already in openMINDS. Before we continue we should double check this. |
ree-gupta
left a comment
There was a problem hiding this comment.
I added my comments for the two formats in the PR that I am familiar with.
| ".tsq", | ||
| ".tbk", | ||
| ".tev", | ||
| ".sev" |
There was a problem hiding this comment.
| ".tsq", | |
| ".tbk", | |
| ".tev", | |
| ".sev" | |
| ".tsq", | |
| ".tbk", | |
| ".Tbk", | |
| ".Tdx", | |
| ".tev", | |
| ".tnt", | |
| ".sev" |
| "displayLabel": null, | ||
| "fileExtension": null, | ||
| "fileExtension": [ | ||
| ".bin", |
There was a problem hiding this comment.
Isn't .bin generic? should we be more specific using the stream names? that is,.ap.bin, .lf.bin and .nidq.bin? Unless the system allows user-defined stream name.
This will replace openMetadataInitiative/openMINDS_core#299.
The comments are in relation to the original PR from @JuliaSprenger and the review comments from @lzehl and @apdavison:
Open questions:
Additionally added: