Skip to content

Add use openRuyi in QEMU/virt-manager#18

Merged
misaka00251 merged 2 commits intoopenRuyi-Project:mainfrom
panglars:main
Apr 30, 2026
Merged

Add use openRuyi in QEMU/virt-manager#18
misaka00251 merged 2 commits intoopenRuyi-Project:mainfrom
panglars:main

Conversation

@panglars
Copy link
Copy Markdown
Contributor

No description provided.

@misaka00251
Copy link
Copy Markdown
Member

Please run npm run write-translations -- --locale zh-Hans once and check if there's any string you need to translate.

@misaka00251 misaka00251 added Type: Documentation Issues relevant to anything documentation. Community: Student contribution Used by contributors that are currently students at an educational institution. labels Apr 20, 2026
Copy link
Copy Markdown

@KevinMX KevinMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall content LGTM, however seems you're mixing half and full width marks, like , and , () and ().

Comment thread i18n/zh-Hans/docusaurus-plugin-content-docs/current/guide/how-to-install/qemu.md Outdated
Comment thread i18n/zh-Hans/docusaurus-plugin-content-docs/current/guide/how-to-install/virt.md Outdated
![cpu](/img/how-to-run/virt/3.png)

### 配置 RISCV EDK II 固件

Copy link
Copy Markdown

@KevinMX KevinMX Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only applies to those who do not have EDK2 firmware packaged with their distros of choice.

Better add a note here, e.g. "此小节仅适用于发行版没有打包 EDK2 固件的发行版,若创建虚拟机时 virt-manager 提示找不到 UEFI 二进制,则请按照以下步骤操作;若没有相关提示,可跳过这一节,virt-manager 会自动使用已安装的 UEFI 固件。"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use this:

:::warning Header

Your content here.

:::

Please also change the English version.

@KevinMX
Copy link
Copy Markdown

KevinMX commented Apr 23, 2026

Please run npm run write-translations -- --locale zh-Hans once and check if there's any string you need to translate.

Tried a local build on my side and overall LGTM. We could probably add a check to our CI?

@panglars
Copy link
Copy Markdown
Contributor Author

Please run npm run write-translations -- --locale zh-Hans once and check if there's any string you need to translate.

fixed

@panglars panglars requested a review from KevinMX April 24, 2026 09:45
Copy link
Copy Markdown

@KevinMX KevinMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please use rebase to get rid of the merge commit.

@misaka00251
Copy link
Copy Markdown
Member

  1. For images, use image-number-<shortdescription>.extension as the filename.
  2. Please add a period at the end of each sentence in your Simplified Chinese version.

Signed-off-by: PangLARS <panghao.riscv@isrc.iscas.ac.cn>
Comment thread i18n/zh-Hans/docusaurus-plugin-content-docs/current/guide/how-to-install/qemu.md Outdated
Copy link
Copy Markdown
Member

@misaka00251 misaka00251 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that in some mixed content, there is no blank space between Chinese and English characters. Please add one for better formatting.

![cpu](/img/how-to-run/virt/3.png)

### 配置 RISCV EDK II 固件

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use this:

:::warning Header

Your content here.

:::

Please also change the English version.

@panglars
Copy link
Copy Markdown
Contributor Author

panglars commented Apr 29, 2026

I noticed that in some mixed content, there is no blank space between Chinese and English characters. Please add one for better formatting.

In 2026, we should manually enable CSS property text-autospace: normal; entire website, instead of manually insert spaces.

@panglars panglars force-pushed the main branch 2 times, most recently from 6ebce6c to 144061a Compare April 29, 2026 07:15
@panglars panglars requested a review from misaka00251 April 29, 2026 07:16
Signed-off-by: PangLARS <panghao.riscv@isrc.iscas.ac.cn>
@misaka00251
Copy link
Copy Markdown
Member

instead of manually insert spaces

I agree text-autospace can help the rendered website, but it doesn’t replace source quality. Since Docusaurus reads Markdown as the source of truth, the Markdown should be readable and correctly formatted by itself—in PR diffs, GitHub previews, editor previews, search, and any non-site output.

We can consider text-autospace as a progressive enhancement, but the PR should still add spaces between Chinese and English/numbers in the source.

@misaka00251 misaka00251 merged commit 0ab4c23 into openRuyi-Project:main Apr 30, 2026
@misaka00251 misaka00251 added the Workflow: Complete Applied after all MRs have merged and the issue has been verified if necessary. label Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community: Student contribution Used by contributors that are currently students at an educational institution. Type: Documentation Issues relevant to anything documentation. Workflow: Complete Applied after all MRs have merged and the issue has been verified if necessary.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants