scripts/remoteassetify.py: A few minor fixes#236
Open
dramforever wants to merge 6 commits intoopenRuyi-Project:mainfrom
Open
scripts/remoteassetify.py: A few minor fixes#236dramforever wants to merge 6 commits intoopenRuyi-Project:mainfrom
dramforever wants to merge 6 commits intoopenRuyi-Project:mainfrom
Conversation
Remove call to strip() while reading spec from stdin to avoid incorrect detection of spec_noeol and patch generation at start or end of file. Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
Make f-string usage compatible with Python < 3.12, where quotes are restricted to be compatible with plain string syntax. Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
Fix problems found by ty check. Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
Fix ruff lints. Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
This script is not a security barrier, so command injection really isn't a concern, but this is still a pedantic but nontheless valid correctness fix. Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
…emoteassetify-minor-fixes
dramforever
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None of these issues actually affect any workflow usage, which is how they've managed to slip under the radar.
AI usage declaration: GPT 5.4 medium found the first two issues through review, but all of PR text and code changes have been done my me manually.