Skip to content

Conversation

@andrii-suse
Copy link
Collaborator

No description provided.

@andrii-suse andrii-suse force-pushed the add_gitea_pr_review_cancel_request branch 2 times, most recently from c7c2dcb to f3c5013 Compare November 13, 2025 08:17
@andrii-suse
Copy link
Collaborator Author

implements #1988

@dmach dmach force-pushed the add_gitea_pr_review_cancel_request branch from f3c5013 to fd9f9c8 Compare December 8, 2025 08:15
Copy link
Contributor

@dmach dmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type hints that reference list suffer from a naming collision,
because there's a list() method in the class.
To fix that, either use List in the type hints, or builtins.list which is an explicit reference to the built-in type.
Using List is probably better as we use it in different places already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants