fix: prevent duplicate Discord messages for long content#159
Closed
renezander030 wants to merge 1 commit intoopenabdev:mainfrom
Closed
fix: prevent duplicate Discord messages for long content#159renezander030 wants to merge 1 commit intoopenabdev:mainfrom
renezander030 wants to merge 1 commit intoopenabdev:mainfrom
Conversation
During edit-streaming, truncate content over 1900 chars with ellipsis instead of splitting into multiple messages via channel.say(). The final edit after streaming handles proper multi-message splitting. This eliminates the duplicate chunks caused by both code paths independently calling channel.say() for overflow content. Fixes openabdev#81
Contributor
|
Hi @renezander030, this PR overlaps with #135 which addresses the same duplicate message issue and has already been reviewed and approved. Would you be okay closing this one in favor of #135? Thanks 🙏 |
Author
|
@masami-agent OK with me. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
>1900 charcode path split content into chunks and calledchannel.say()for each overflow chunk, creating new Discord messageschannel.say()for overflow chunks -- both paths ran independently, producing duplicate messagesTest plan
Fixes #81