build(docker): update codex-acp to 0.11.1 and add runtime utilities#250
build(docker): update codex-acp to 0.11.1 and add runtime utilities#250clsung wants to merge 1 commit intoopenabdev:mainfrom
Conversation
clsung
commented
Apr 12, 2026
- Upgrade @zed-industries/codex-acp from 0.9.5 to 0.11.1.
- Install procps and ripgrep in the runtime stage to support improved process monitoring (health check) and search capabilities (rg) within the container.
- Upgrade @zed-industries/codex-acp from 0.9.5 to 0.11.1. - Install procps and ripgrep in the runtime stage to support improved process monitoring (health check) and search capabilities (rg) within the container.
masami-agent
left a comment
There was a problem hiding this comment.
Review — PR #250
Clean, minimal change. Two items:
✅ What looks good
- codex-acp 0.9.5 → 0.11.1 — version bump is straightforward
ripgrepaddition — useful for agent search capabilities inside the container- Single file, +2/-2 lines — tight scope
🟡 Potential overlap with PR #234
PR #234 (fix(docker): install procps for healthchecks) also adds procps to Dockerfile.codex (and all other Dockerfiles). If #234 merges first, this PR will have a merge conflict on the same apt-get install line.
Suggestion: coordinate with #234 — whoever merges first, the other should rebase. Or if both are ready, merge #234 first (it covers all 4 Dockerfiles) and then this PR only needs the codex-acp version bump + ripgrep.
Question
@clsung — is the codex-acp 0.11.1 upgrade a breaking change or backward compatible? Any release notes worth noting?
Otherwise this is ready to approve once the overlap with #234 is sorted out.
masami-agent
left a comment
There was a problem hiding this comment.
Re-review — PR #250
Summary
- Problem: Bump codex-acp version and add runtime utilities to
Dockerfile.codex - Approach: codex-acp 0.9.5 → 0.11.1, add
procpsandripgrepto apt-get install - Risk level: Low (single Dockerfile, +2/-2)
Current Status
This PR is 212 commits behind main and has been overtaken by subsequent changes:
-
procpsis already onmain— the currentDockerfile.codexonmainalready includesprocpsin theapt-get installline. This part of the PR is now redundant. -
Codex CLI is now pinned via
ARG—mainnow usesARG CODEX_VERSION=0.120.0with@openai/codex@${CODEX_VERSION}, but this PR's diff still uses the old unpinned@openai/codex(no version). After rebase, this would need to align with the new pinning pattern. -
codex-acp version — the PR bumps
@zed-industries/codex-acpfrom 0.9.5 → 0.11.1. Onmain, codex-acp is still at 0.9.5, so this part is still relevant. -
ripgrep— not onmaincurrently, so this addition is still relevant.
Review Summary
🔴 Blockers
- 212 commits behind
main— massive divergence. The diff will conflict on theapt-get installline and thenpm installline (which now usesARG CODEX_VERSION).
💬 Questions
- @clsung — this PR has been open since April 12 and is now very stale. Are you still planning to pursue this? If so, a rebase is needed. After rebase, the remaining useful changes would be:
- codex-acp 0.9.5 → 0.11.1
- Adding
ripgrepto the apt-get line
- (
procpsis already onmain, and codex CLI pinning pattern has changed)
ℹ️ Info
- PR #234 (which my previous review flagged as overlapping) is still open but
procpshas already landed onmainthrough other work. - The
response-requestedandp1labels suggest this was flagged for contributor action. - My previous review question about codex-acp 0.11.1 backward compatibility was never answered.
Verdict
REQUEST_CHANGES — needs rebase (212 commits behind) and the contributor should confirm whether they want to continue. The codex-acp bump and ripgrep addition are still valuable, but the PR needs significant rework to align with current main.
|