Skip to content

build(docker): update codex-acp to 0.11.1 and add runtime utilities#250

Closed
clsung wants to merge 1 commit intoopenabdev:mainfrom
clsung:dockerfile-codex
Closed

build(docker): update codex-acp to 0.11.1 and add runtime utilities#250
clsung wants to merge 1 commit intoopenabdev:mainfrom
clsung:dockerfile-codex

Conversation

@clsung
Copy link
Copy Markdown
Contributor

@clsung clsung commented Apr 12, 2026

  • Upgrade @zed-industries/codex-acp from 0.9.5 to 0.11.1.
  • Install procps and ripgrep in the runtime stage to support improved process monitoring (health check) and search capabilities (rg) within the container.

- Upgrade @zed-industries/codex-acp from 0.9.5 to 0.11.1.
- Install procps and ripgrep in the runtime stage to support improved
  process monitoring (health check) and search capabilities (rg)
  within the container.
@clsung clsung requested a review from thepagent as a code owner April 12, 2026 05:56
@thepagent thepagent added the p1 High — address this sprint label Apr 15, 2026
Copy link
Copy Markdown
Contributor

@masami-agent masami-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review — PR #250

Clean, minimal change. Two items:

✅ What looks good

  1. codex-acp 0.9.5 → 0.11.1 — version bump is straightforward
  2. ripgrep addition — useful for agent search capabilities inside the container
  3. Single file, +2/-2 lines — tight scope

🟡 Potential overlap with PR #234

PR #234 (fix(docker): install procps for healthchecks) also adds procps to Dockerfile.codex (and all other Dockerfiles). If #234 merges first, this PR will have a merge conflict on the same apt-get install line.

Suggestion: coordinate with #234 — whoever merges first, the other should rebase. Or if both are ready, merge #234 first (it covers all 4 Dockerfiles) and then this PR only needs the codex-acp version bump + ripgrep.

Question

@clsung — is the codex-acp 0.11.1 upgrade a breaking change or backward compatible? Any release notes worth noting?

Otherwise this is ready to approve once the overlap with #234 is sorted out.

Copy link
Copy Markdown
Contributor

@masami-agent masami-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — PR #250

Summary

  • Problem: Bump codex-acp version and add runtime utilities to Dockerfile.codex
  • Approach: codex-acp 0.9.5 → 0.11.1, add procps and ripgrep to apt-get install
  • Risk level: Low (single Dockerfile, +2/-2)

Current Status

This PR is 212 commits behind main and has been overtaken by subsequent changes:

  1. procps is already on main — the current Dockerfile.codex on main already includes procps in the apt-get install line. This part of the PR is now redundant.

  2. Codex CLI is now pinned via ARGmain now uses ARG CODEX_VERSION=0.120.0 with @openai/codex@${CODEX_VERSION}, but this PR's diff still uses the old unpinned @openai/codex (no version). After rebase, this would need to align with the new pinning pattern.

  3. codex-acp version — the PR bumps @zed-industries/codex-acp from 0.9.5 → 0.11.1. On main, codex-acp is still at 0.9.5, so this part is still relevant.

  4. ripgrep — not on main currently, so this addition is still relevant.

Review Summary

🔴 Blockers

  • 212 commits behind main — massive divergence. The diff will conflict on the apt-get install line and the npm install line (which now uses ARG CODEX_VERSION).

💬 Questions

  • @clsung — this PR has been open since April 12 and is now very stale. Are you still planning to pursue this? If so, a rebase is needed. After rebase, the remaining useful changes would be:
    1. codex-acp 0.9.5 → 0.11.1
    2. Adding ripgrep to the apt-get line
    • (procps is already on main, and codex CLI pinning pattern has changed)

ℹ️ Info

  • PR #234 (which my previous review flagged as overlapping) is still open but procps has already landed on main through other work.
  • The response-requested and p1 labels suggest this was flagged for contributor action.
  • My previous review question about codex-acp 0.11.1 backward compatibility was never answered.

Verdict

REQUEST_CHANGES — needs rebase (212 commits behind) and the contributor should confirm whether they want to continue. The codex-acp bump and ripgrep addition are still valuable, but the PR needs significant rework to align with current main.

@chaodu-agent
Copy link
Copy Markdown
Collaborator

% docker run --rm --entrypoint npm ghcr.io/openabdev/openab-codex:0.7.7 view @zed-industries/codex-acp version
0.11.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1 High — address this sprint response-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants