Skip to content

fix(discord): react 🎤 on voice messages when STT is disabled#252

Merged
thepagent merged 1 commit intoopenabdev:mainfrom
shaun-agent:fix/voice-msg-feedback-when-stt-disabled
Apr 15, 2026
Merged

fix(discord): react 🎤 on voice messages when STT is disabled#252
thepagent merged 1 commit intoopenabdev:mainfrom
shaun-agent:fix/voice-msg-feedback-when-stt-disabled

Conversation

@shaun-agent
Copy link
Copy Markdown
Contributor

Summary

When STT is not configured, voice messages were silently dropped — no reaction, no reply. Users thought the bot was broken.

Closes #251

Changes

File Change Lines
src/discord.rs Add warn import, track audio_skipped, react 🎤, early return +13, -2

What it does

  1. Track skipped audioaudio_skipped bool set when an audio attachment is encountered with STT disabled
  2. Upgrade log leveldebug!()warn!() so operators see it in production logs
  3. React 🎤 — on the original message, consistent with existing 🚫 pattern for denied users
  4. Early return for voice-only — if prompt.is_empty() and only the sender_context block exists in content_blocks, bail out instead of sending an empty prompt to the agent
  5. Mixed messages still work — text + voice → process text, react 🎤 to signal audio was ignored

Behavior matrix

Message type STT enabled STT disabled (after this PR)
Voice only Transcribe → process React 🎤 → early return ✅
Voice + text Transcribe → process all React 🎤 → process text only ✅
Voice + image Transcribe → process all React 🎤 → process image only ✅
Text only Process Process (unchanged)

Related

@shaun-agent shaun-agent marked this pull request as ready for review April 14, 2026 05:06
@shaun-agent shaun-agent requested a review from thepagent as a code owner April 14, 2026 05:06
@thepagent thepagent added the p1 High — address this sprint label Apr 15, 2026
When STT is not configured, voice messages were silently dropped — no
reaction, no reply. Users thought the bot was broken.

Changes:
- Track audio_skipped flag during attachment processing
- Upgrade debug!() → warn!() for operator log visibility
- React with 🎤 emoji so users know their voice message was noticed
- Early return for voice-only messages to avoid sending empty prompts
  to the downstream agent

For mixed messages (text + voice), the text is still processed normally
and the 🎤 reaction signals that the audio portion was ignored.
@shaun-agent shaun-agent force-pushed the fix/voice-msg-feedback-when-stt-disabled branch from ab03835 to d4c934b Compare April 15, 2026 03:23
@github-actions github-actions bot added the closing-soon PR missing Discord Discussion URL — will auto-close in 3 days label Apr 15, 2026
@github-actions
Copy link
Copy Markdown

⚠️ This PR is missing a Discord Discussion URL in the body.

All PRs must reference a prior Discord discussion to ensure community alignment before implementation.

Please edit the PR description to include a link like:

Discord Discussion URL: https://discord.com/channels/...

This PR will be automatically closed in 3 days if the link is not added.

@thepagent thepagent merged commit f28f704 into openabdev:main Apr 15, 2026
7 checks passed
dogzzdogzz added a commit to dogzzdogzz/openab that referenced this pull request Apr 15, 2026
Resolve discord.rs conflict — take our refactored version and port
upstream's 🎤 reaction for voice messages when STT is disabled (openabdev#252).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closing-soon PR missing Discord Discussion URL — will auto-close in 3 days p1 High — address this sprint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: voice messages silently dropped when STT is not configured

4 participants