fix: exempt bot-authored PRs from Discord discussion URL check#349
Merged
fix: exempt bot-authored PRs from Discord discussion URL check#349
Conversation
Release PRs created by openab-app bot don't need a Discord discussion URL. Skip the check when pr.user.type is Bot, and clean up any existing warning comment/label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the issue where
openab-apprelease PRs (e.g. #346) get flagged by the Discord Discussion URL check and labeledclosing-soon.Problem
The
pr-discussion-check.ymlworkflow requires every PR to include a Discord discussion URL. Bot-authored release PRs (created byopenab-app[bot]) don't have one and shouldn't need one — they're automated version bumps.PR #346 (
release: v0.7.5-beta.1) was flagged and will be auto-closed in 3 days byclose-stale-prs.yml.Fix
Skip the check when
pr.user.type === 'Bot'. Also cleans up any existing warning comment andclosing-soonlabel if the workflow re-runs on a bot PR.Discord Discussion URL: https://discord.com/channels/1352702813/1493128598654029996