fix(ci): add cursor to smoke-test + rebase PR #301 onto main#369
Closed
fix(ci): add cursor to smoke-test + rebase PR #301 onto main#369
Conversation
Add Cursor Agent CLI as a new agent backend using native ACP support (`cursor-agent acp`). Includes Dockerfile with pinned version download, CI matrix entries, Helm chart config, and documentation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Align with kiro Dockerfile conventions: - Rename user from 'node' to 'agent' (uid 1000) - Use cp instead of symlink for cursor-agent binary - Pre-create ~/.cursor/ directory - Fix docs/cursor.md token path from ~/.cursor-agent/ to ~/.cursor/ Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cursor-agent creates the directory on first run. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Extract tarball directly to /opt, rename dist-package to cursor-agent - Remove preview warning from README agent table - Add Model Selection section to docs/cursor.md - Fix workingDir in Helm example (/home/node → /home/agent) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
HEALTHCHECK uses `pgrep -x openab`, which requires procps. Debian slim does not ship with it, so the healthcheck was silently failing (command not found) and the pod would enter Unhealthy state. Same fix pattern as pending PR #234 for the other Dockerfiles. Addresses review comment on PR #301 from @masami-agent.
Add a comment explaining the Cursor tarball URL pattern (downloads.cursor.com/lab/<version>/linux/<arch>/...) and that it's scraped from the official downloads page — there's no apt/yum package. If Cursor changes the URL scheme, the build will fail with a curl 404 at build time, so future maintainers have a hint of where to check. Addresses non-blocking review comment on PR #301 from @masami-agent.
Document how MCP servers are configured in cursor-agent ACP mode: - The `--workspace` flag determines which `.cursor/mcp.json` is loaded and which approvals slug is used — explicit is safer than relying on cwd auto-detection. - `--approve-mcps` does NOT apply in ACP mode (interactive CLI only); MCP load gating uses an approval file at .cursor/projects/<slug>/mcp-approvals.json. - Two paths to approve: pre-create the file, or approve once interactively so Cursor persists it. - openab auto-replies session/request_permission with allow_always, so once loaded, subsequent tool calls pass without prompting. - Verify with `cursor-agent mcp list`. Part of PR #301 polish.
github-actions
bot
added
the
closing-soon
|
All PRs must reference a prior Discord discussion to ensure community alignment before implementation. Please edit the PR description to include a link like: This PR will be automatically closed in 3 days if the link is not added. |
Collaborator
Author
|
Superseded — changes pushed directly to PR #301 (brettchien/feat/cursor-agent-cli). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebases PR #301 (feat: add Cursor Agent CLI support) onto current main and adds the two missing items:
.github/workflows/docker-smoke-test.yml— add-cursorvariant (was present for opencode in feat: add OpenCode as ACP agent backend #258, missing for cursor in feat: add Cursor Agent CLI support #301)charts/openab/Chart.yaml— aligned to main (0.7.6-beta.1) via rebase (PR feat: add Cursor Agent CLI support #301 branch was on0.7.3-beta.56)Also resolves rebase conflicts in
build.yml,values.yaml,config.toml.examplekeeping both opencode and cursor entries.Closes #301