fix(helm): default discord.enabled to true when botToken is present#394
Merged
thepagent merged 1 commit intoopenabdev:mainfrom Apr 16, 2026
Merged
Conversation
|
All PRs must reference a prior Discord discussion to ensure community alignment before implementation. Please edit the PR description to include a link like: This PR will be automatically closed in 3 days if the link is not added. |
github-actions
bot
added
the
closing-soon
thepagent
force-pushed
the
fix/helm-discord-enabled-default
branch
2 times, most recently
from
e9a91c7 to
b476d8e
Compare
The 0.7.7-beta.1 chart added a discord.enabled guard but existing deployments upgrading from 0.7.6 don't have this field set, causing the [discord] section and discord-bot-token secret to be omitted entirely — resulting in CrashLoopBackOff. Change the guard from requiring enabled to be truthy to only skipping when enabled is explicitly "false", preserving backwards compatibility. Fixes openabdev#383
thepagent
force-pushed
the
fix/helm-discord-enabled-default
branch
from
b476d8e to
5e4be98
Compare
5 tasks
JARVIS-coding-Agent
added a commit
to JARVIS-coding-Agent/openab
that referenced
this pull request
Apr 17, 2026
…nfigs When upgrading from 0.7.6 to 0.7.7, per-agent discord configs that lack the new discord.enabled field fail to render the [discord] TOML section, causing pods to crash with 'no adapter configured'. Replace the strict boolean check with a backward-compatible condition that also considers the presence of botToken, matching the intent of openabdev#394. Closes openabdev#416
JARVIS-coding-Agent
added a commit
to JARVIS-coding-Agent/openab
that referenced
this pull request
Apr 17, 2026
…nfigs When upgrading from 0.7.6 to 0.7.7, per-agent discord configs that lack the new discord.enabled field fail to render the [discord] TOML section, causing pods to crash with 'no adapter configured'. Replace the strict boolean check with a backward-compatible condition that also considers the presence of botToken, matching the intent of openabdev#394. Closes openabdev#416
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Upgrading from 0.7.6 → 0.7.7-beta.1 causes
CrashLoopBackOffbecause the newdiscord.enabledguard in configmap.yaml and secret.yaml requires the field to be explicitly set. Existing deployments from 0.7.6 don't havediscord.enabledin their values, so the[discord]section anddiscord-bot-tokensecret entry are silently omitted.Root Cause
The 0.7.7-beta.1 Slack adapter PR added this guard:
{{- if and ($cfg.discord).enabled ($cfg.discord).botToken }}When
discord.enabledis absent (not set), Go templates evaluate it as falsy → entire[discord]block is skipped.Fix
Change the guard to only skip when
enabledis explicitly"false":{{- if and (ne (toString ($cfg.discord).enabled) "false") ($cfg.discord).botToken }}This preserves backwards compatibility with 0.7.6 values (no
enabledfield) while still allowing explicitdiscord.enabled: falsefor Slack-only setups.Verified
[discord]section, secret hasdiscord-bot-token.Fixes #383