fix(helm): decouple [discord] section from botToken presence#403
Merged
thepagent merged 2 commits intoopenabdev:mainfrom Apr 16, 2026
Merged
fix(helm): decouple [discord] section from botToken presence#403thepagent merged 2 commits intoopenabdev:mainfrom
thepagent merged 2 commits intoopenabdev:mainfrom
Conversation
- Change discord condition from requiring botToken to only checking enabled flag - Remove botToken from kiro agent defaults (injected at runtime via DISCORD_BOT_TOKEN env var) - Add enabled: true to commented-out agent examples for clarity Closes openabdev#392
This was referenced Apr 16, 2026
4baab6b to
7493cec
Compare
Covers discord/slack enabled flag logic to prevent regressions like openabdev#392. Uses helm-unittest YAML format instead of bash scripts.
7493cec to
d253603
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #392.
Supersedes #393 (rebased onto current
main, removed stale/duplicate Slack section, updatedvalues.yaml).Reason for this change
The
[discord]block inconfig.tomlis conditionally rendered only when($cfg.discord).botTokenis non-empty. This forces users who manage secrets at runtime (e.g., AWS Secrets Manager → K8s Secret → env var) to either:The template already hardcodes
bot_token = "${DISCORD_BOT_TOKEN}"as a placeholder for runtime expansion, so requiringbotTokenin Helm values serves no purpose other than gating the block.Description of changes
configmap.yaml (one-line change):
values.yaml:
botTokenfrom the kiro agent discord section (no longer needed at render time)DISCORD_BOT_TOKENenv varenabled: trueto all commented-out agent examples (claude, opencode, cursor) so users see the correct patternThis changes the discord condition from opt-out (
enableddefaults to true unless"false") to opt-in (enabledmust be explicitlytrue).Who is affected: Users who have
discord.botTokenset but never explicitly setdiscord.enabled: true. After this change, their[discord]block will not render.Migration: Add
discord.enabled: trueto your agent's discord values.Context