fix php, more jdk versions #111
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2670259735
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | `CODEX_ENV_SWIFT_VERSION` | Swift version to install | `5.10`, `6.1`, `6.2` | | | ||
| | `CODEX_ENV_RUBY_VERSION` | Ruby version to install | `3.2.3`, `3.3.8`, `3.4.4` | | | ||
| | `CODEX_ENV_PHP_VERSION` | PHP version to install | `8.4`, `8.3`, `8.2` | | | ||
| | `CODEX_ENV_JAVA_VERSION` | JDK version to install | `25`, `24`, `23`, `22`, `21`, `17`, `11` | | |
There was a problem hiding this comment.
The README now advertises CODEX_ENV_JAVA_VERSION, but setup_universal.sh only checks Python/Node/Ruby/Rust/go/Swift/PHP variables and never reads CODEX_ENV_JAVA_VERSION, so the variable is ignored and users will still get the default JDK (currently java@25 from the Dockerfile). This will silently misconfigure anyone trying to pin Java for a build.
Useful? React with 👍 / 👎.
1 participant
No description provided.