Fix fetch credentials option casing#4
Open
tristanmanchester wants to merge 1 commit intoopenai:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Credentialsproperty to the standard lowercasecredentialsproperty.RequestInitannotations so TypeScript validates these objects against the browser fetch API contract.Bug
fetchonly readsRequestInit.credentials; JavaScript object keys are case-sensitive, soCredentials: 'include'is treated as an unrelated property and silently ignored. For cross-origin deployments this leaves the request at the browser default credentials behavior, so cookies and other credentials are not included even though the server enables credentialed CORS.Fix
Updated the three affected request option objects:
src/utils/api-manager.tsJSONL fetchsrc/utils/api-manager.tsrenderer list refreshsrc/components/app/request-worker.tstranslation requestEach now uses
credentials: 'include'and is typed asRequestInit, which prevents future casing or value mistakes from bypassing TypeScript.Verification
srcfor remaining uppercaseCredentials:request options; none remain.pnpm run buildsuccessfully.