Skip to content

Fix translation of string message content #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tristanmanchester wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix translation of string message content #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions src/components/conversation/conversation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1089,17 +1089,22 @@ export class EuphonyConversation extends LitElement {
// We only translate [text messages, developer messages]
const contentType = getContentTypeFromContent(message.content);
if (contentType === 'text' || contentType === 'developer') {
const content = [message.content[0]];
// Ignore the below check because ts wants us to split it into n
// different conditions
// @ts-ignore
const translatableMessage: TranslatableMessage = {
...message,
content: content as
| TextMessageContent[]
| DeveloperContentMessageContent[],
isTranslated: false
};
// Normalize string content into a text object before translating so
// downstream updates mutate the translated message clone.
const content = getContentFromContentOrString(message.content);
const translatableMessage: TranslatableMessage =
contentType === 'text'
? {
...translatedMessages[i],
content: [content as TextMessageContent],
isTranslated: false
}
: {
...translatedMessages[i],
content: [content as DeveloperContentMessageContent],
isTranslated: false
};
translatedMessages[i] = translatableMessage;
promises.push(updateMessageWithTranslation(translatableMessage, i));
}
}
Expand Down