-
Notifications
You must be signed in to change notification settings - Fork 389
fix: #425 improve the compatibility for conversationId / previousResponseId + tool calls #556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 9e6afaf The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@codex review |
Since this repo has issues with codex review integration right now, I ran /review command locally, and got the following feedback. This is fair, so need to improve the implementation:
Checked Python repo too:
So the TypeScript regression isn’t applicable to the present Python implementation. If we later expose a resumable state similar to TS, we’ll need to seed _ServerConversationTracker with prior items (or skip replay on the |
This pull request brings openai/openai-agents-python#1827 improvements to TS SDK as well.
Resolves #425
See also: openai/openai-agents-python#1789