-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add SQLAlchemy session backend for conversation history management #1357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The new
The Temporary Solution As a temporary measure to allow the feature to be merged without breaking the build, the following changes have been made:
Next Steps This solution is a trade-off. It prevents the CI from breaking, but it means that the I think the correct long-term fix is to update Let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a glance, this looks good to me; @rm-openai any thoughts?
@habema could you resolve the conflict? |
@seratch you got it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this enhancement looks good to me; great work 👍
This PR introduces
SQLAlchemySession
, providing a production-grade session storage backend that can connect to any database supported by SQLAlchemy (e.g., PostgreSQL, MySQL).This implementation is based on the discussion in Issue #1328 and follows the agreed-upon architectural pattern:
src/agents/extensions/memory/
.[sqlalchemy]
extra.A test has been added.
Resolves #1328.