fix compilation error in #69 #92
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: As mentioned in [this comment](openai#69 (comment)) of openai#69, a compilation crashes due to an error of unused variables on Apple silicon (with clang 14 and possibly 13+). This issue has been reported [elsewhere](ClickHouse/ClickHouse#27705). This seems to be caused by breaking behavior in clang 13 which escalates unused variable from a warning in prior versions to an error. The solution implemented here: I add an additional cflags `-Wno-unused-but-set-variable` for apple platforms. Tested on macOS 13.3.1 with Apple clang version 14.0.3 (clang-1403.0.22.14.1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
As mentioned in this comment of #69, a compilation crashes due to an error of unused variables on Apple silicon (with clang 14 and possibly 13+). This issue has been reported elsewhere. This seems to be caused by breaking behavior in clang 13 which escalates unused variable from a warning in prior versions to an error.
The solution implemented here:
I add an additional cflags
-Wno-unused-but-set-variablefor apple platforms.Tested on macOS 13.3.1 with Apple clang version 14.0.3 (clang-1403.0.22.14.1)