Escape dashboard HTML payload before rendering#22
Merged
frantic-openai merged 1 commit intomainfrom Mar 3, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR mitigates stored XSS risk in the dashboard root HTML endpoint by HTML-escaping the JSON payload before rendering it into the dashboard <pre> block.
Changes:
- Escape HTML-sensitive characters in
SymphonyElixir.HttpServer.render_dashboard/3before interpolating JSON into the HTML response. - Add a regression test ensuring
<script>content in the dashboard payload is rendered escaped (not executable).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
elixir/lib/symphony_elixir/http_server.ex |
Escapes the rendered dashboard JSON payload before embedding in HTML. |
elixir/test/symphony_elixir/extensions_test.exs |
Adds an end-to-end regression test for HTML escaping in the dashboard root endpoint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Prevent stored XSS in the dashboard root HTML endpoint by escaping JSON payload characters before rendering.
TL;DR
Escape dashboard JSON output before injecting it into the
<pre>element.Summary
SymphonyElixir.HttpServer.render_dashboard/3.<script>in dashboard payload is escaped.Alternatives
Test Plan
mix test test/symphony_elixir/extensions_test.exsmake -C elixir all