Fix terminal dashboard ANSI/control byte injection#23
Merged
frantic-openai merged 1 commit intomainfrom Mar 3, 2026
Merged
Conversation
Summary: - sanitize humanize_codex_payload output by stripping ANSI escape sequences and control bytes - keep existing newline and spacing normalization behavior - add regression coverage for ANSI and NUL-control payloads in status dashboard Rationale: - prevents terminal injection/malicious formatting in dashboard event lines - avoids control-byte escape rendering while preserving readable normal messages Tests: - mix test test/symphony_elixir/orchestrator_status_test.exs - cd elixir && make all (fails due flaky existing timing test, unrelated) Co-authored-by: Codex <codex@openai.com>
frantic-openai
deleted the
frantic/mt-898-terminal-output-injection-ansicontrol-chars-in-terminal
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Protect the dashboard status terminal from ANSI and control-byte payloads so tool outputs can’t inject terminal formatting.
TL;DR
Sanitize Codex payload text before dashboard rendering to drop ANSI and control bytes.
Summary
humanize_codex_payload.Alternatives
Test Plan
make -C elixir allmix test test/symphony_elixir/orchestrator_status_test.exs