Silence noisy Elixir make-all task output#24
Merged
frantic-openai merged 1 commit intomainfrom Mar 3, 2026
Merged
Conversation
Summary: - capture expected stderr/stdout in task tests so passing runs stay quiet - ignore test support helpers in Mix's test loader to avoid cover warnings Rationale: - keep `make all` output actionable by removing intentional failure-path noise from passing tests - align test discovery with Elixir 1.19, which warns on unmatched helper files Tests: - `mix test test/mix/tasks/pr_body_check_test.exs` - `mix test test/mix/tasks/workspace_before_remove_test.exs` - `mix test --cover` - `make all` Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Expected Mix task stderr/stdout and Elixir 1.19 helper-file warnings made
make -C elixir alllook broken even when it passed.TL;DR
Silence expected task-test output and ignore helper files so
make -C elixir allstays clean.Summary
workspace.before_removetests to assert both streams without noisy console output.test/support/*.exsin Mix test loading to remove Elixir 1.19 cover warnings.Alternatives
make -C elixir alllooking unhealthy and hides real failures.Test Plan
make -C elixir allcd elixir && mix test test/mix/tasks/pr_body_check_test.exscd elixir && mix test test/mix/tasks/workspace_before_remove_test.exs