Skip to content

Loosen up the opencensus dependency#6

Merged
hauleth merged 1 commit intoopencensus-beam:masterfrom
tpitale:patch-2
Jul 15, 2019
Merged

Loosen up the opencensus dependency#6
hauleth merged 1 commit intoopencensus-beam:masterfrom
tpitale:patch-2

Conversation

@tpitale
Copy link
Copy Markdown
Contributor

@tpitale tpitale commented Apr 4, 2019

Will allow for oc_datadog to work with opencensus_phoenix and others. Resolves #5

Will allow for oc_datadog to work with opencensus_phoenix and others. Resolves #5
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 4, 2019

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master      #6   +/-   ##
======================================
  Coverage    67.9%   67.9%           
======================================
  Files           2       2           
  Lines          81      81           
======================================
  Hits           55      55           
  Misses         26      26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acd987d...c0ed658. Read the comment docs.

@tpitale
Copy link
Copy Markdown
Contributor Author

tpitale commented Apr 4, 2019

Attempting to resolve a similar issue I guess to #3 I'm hoping that ~> 0.7 works better than ~> 0.7.0, though I don't know how strict opencensus is with semver.

I guess this is also because mix is more strict with versioning.

@hauleth
Copy link
Copy Markdown
Contributor

hauleth commented Apr 4, 2019

@tpitale it is quite strict, the problem is that 0.x.y do not guarantee any stability accordingly to specs.

@0x6a68
Copy link
Copy Markdown

0x6a68 commented Jul 15, 2019

resolution?

@hauleth hauleth self-requested a review July 15, 2019 11:54
@hauleth hauleth merged commit 0025b03 into opencensus-beam:master Jul 15, 2019
@0x6a68
Copy link
Copy Markdown

0x6a68 commented Jul 15, 2019

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update opencensus dependency

4 participants