Skip to content

fix: fix component logLevels filter when all log levels are selected#490

Merged
rashadism merged 1 commit intoopenchoreo:mainfrom
akila-i:obs-comp-logs-filter-fix
Apr 3, 2026
Merged

fix: fix component logLevels filter when all log levels are selected#490
rashadism merged 1 commit intoopenchoreo:mainfrom
akila-i:obs-comp-logs-filter-fix

Conversation

@akila-i
Copy link
Copy Markdown
Contributor

@akila-i akila-i commented Apr 3, 2026

Purpose

Fix issue in PR #486

On the component-level runtime logs page, selecting the 'All' option in the log level filter did not trigger an API call, resulting in no logs being displayed. The project-level logs page worked correctly with the same selection. This PR includes the change to fix the component-level logs page.

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed runtime logs filtering behavior when all log levels are selected.

Signed-off-by: Akila-I <akila.99g@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 59711969-0307-40ff-bc84-8f3f6bf39000

📥 Commits

Reviewing files that changed from the base of the PR and between 0930ac9 and ea9fcc1.

📒 Files selected for processing (1)
  • plugins/openchoreo-observability/src/components/RuntimeLogs/ObservabilityRuntimeLogsPage.tsx

📝 Walkthrough

Walkthrough

A single-line parameter selection logic change in the observability runtime logs component. When all log levels are selected, the hook now passes undefined instead of an empty array to represent the "all selected" state, while partial selections continue using the filters object.

Changes

Cohort / File(s) Summary
Runtime Logs Parameter Logic
plugins/openchoreo-observability/src/components/RuntimeLogs/ObservabilityRuntimeLogsPage.tsx
Changed logLevels parameter from empty array to undefined when all log levels are selected; partial selections remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A tiny tweak, so neat and small,
When levels align—that's none at all!
Undefined now speaks the truth,
All selected, fresh as youth! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description partially completes the template with Purpose section addressing the issue, but lacks Goals, Approach, and all other required sections, leaving most fields as unfilled template placeholders. Complete missing sections including Goals, Approach, Release note, Documentation, and other relevant sections, or mark inapplicable sections as 'N/A' with brief explanations.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: fixing the logLevels filter behavior when all log levels are selected in the component-level runtime logs page.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rashadism rashadism merged commit 1e5376a into openchoreo:main Apr 3, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants