Skip to content

Conversation

@lambaaryan011
Copy link
Contributor

Pull Request

Description

This PR updates the GitHub Actions workflow to push Docker images to GitHub Container Registry (GHCR) instead of Docker Hub.

Changes include:

⇾ Updating push-docker.yml to use ghcr.io as the registry
⇾ Replacing Docker Hub login credentials with GitHub credentials (GITHUB_TOKEN)
⇾ Updating image tags to follow GHCR naming conventions
Fixes #69

How Has This Been Tested?

The workflow was tested by triggering a test run in GitHub Actions:

⇾ Verified that the Docker image builds successfully
⇾ Checked that the image is pushed to GHCR (ghcr.io/openclimatefix/...)
⇾ Pulled the image locally to confirm it is accessible and usable

  • Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Signed-off-by: aryan lamba <aryanlamba54@gmail.com>
@lambaaryan011
Copy link
Contributor Author

@peterdudfield have a look

@peterdudfield
Copy link
Contributor

@devsjc would you be able to look at this? Thanks

@lambaaryan011
Copy link
Contributor Author

Hi @devsjc @peterdudfield ,

Just following up on my PR. Could you please review it when you get a chance? Let me know if any changes are needed

@lambaaryan011 lambaaryan011 changed the title Udpate to push to GCHR update to push to GCHR Mar 15, 2025
@peterdudfield
Copy link
Contributor

@devsjc you ok to review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Udpate to push to GCHR

2 participants