Update openjson #61
Update openjson #61
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
+ Coverage 31.89% 31.95% +0.05%
==========================================
Files 311 311
Lines 33703 37984 +4281
==========================================
+ Hits 10750 12136 +1386
- Misses 22953 25848 +2895 ☔ View full report in Codecov by Sentry. |
vijayabhaskar78
force-pushed
the
update-openjson
branch
from
24893c6 to
6764c3f
Compare
|
closes #58 |
docs/BidOfferApi.md
Outdated
| import elexonpy | ||
| from elexonpy.rest import ApiException | ||
| import swagger_client | ||
| from swagger_client.rest import ApiException |
There was a problem hiding this comment.
can you change back to elexonpy please. This might be an option when you generatte the code
There was a problem hiding this comment.
OK sir I will change it, if you don't mind I have sent you a LinkedIn message please have a look at it.
|
Done sir but I did not get why the codecov/patch is failing it you don't mind please explain me sir and please view my Linkedin message which I have sent sir |
| return (return_data) | ||
| else: | ||
| return (return_data, response_data.status, | ||
| response_data.getheaders()) | ||
|
|
||
| def format_to_dataframe(self, query_params): |
There was a problem hiding this comment.
could you add this back in please?
There was a problem hiding this comment.
could you add this back in, in the same format please
|
Sir, I have resolved the issues as per your suggestions. |
|
@peterdudfield Sir please review this PR |
|
|
||
| # **balancing_physical_get** | ||
| > InsightsApiModelsResponsesResponseWithMetadata1InsightsApiModelsResponsesBalancingPhysicalPhysicalData balancing_physical_get(bm_unit, _from, to, settlement_period_from=settlement_period_from, settlement_period_to=settlement_period_to, dataset=dataset, format=format) | ||
| # **get_balancing_physical_bmunit_bmunit_from_from_to_to** |
There was a problem hiding this comment.
do you know why the functions have changed names? They seem less readable now.
There was a problem hiding this comment.
They have been updated by 2to3 tool sir as the functions names will be changed in it like the traces of python 2 will be removed
There was a problem hiding this comment.
can this be changed back?
Thanks, ive left 2 comment. Can you also confirm the examples in the readme and in the example folder still work. Thanks |
|
@peterdudfield I sincerely apologize for the delay. I've been searching for ways to improve the function names, wanting to make sure we get them just right. Unfortunately, we can’t revert them back to the old ones, but I truly appreciate your patience and understanding. |
2 participants
When I have updated the repository to new json requirements it has added python 2 code and I have used 2to3 tool to convert the generated repository to python 3