Next hop group attribute to specify if weights are achieved by repeating members or via the weighting support in the hardware.. #2166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogrammed by repeating the next hop members in proportion to their weight or by using the intrinsic next hop group weight support in the hardware. Signed-off-by: Kishore Gummadidala <kishorg@google.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
approved these changes
Apr 24, 2025
Contributor
rck-innovium
left a comment
rck-innovium
left a comment
There was a problem hiding this comment.
Need more understanding so as to standardize the expected behavior.
| * | ||
| * @type bool | ||
| * @flags CREATE_AND_SET | ||
| * @default false |
Contributor
There was a problem hiding this comment.
The default value of "false" will NOT be backward compatible for devices that support Native WCMP.
The name of this attribute must be SAI_NEXT_HOP_GROUP_ATTR_DISABLE_NATIVE_WCMP with default value as False.
|
|
||
| /** | ||
| * @brief Weighted multi path configuration mode. | ||
| * false: Nexthop group is programmed with repeated member entries proportional to their weight |
Contributor
There was a problem hiding this comment.
When the SAI implementation repeats next hop group member entries, should the SAI_SWITCH_ATTR_AVAILABLE_NEXT_HOP_GROUP_MEMBER_ENTRY attribute be updated to reflect the count of the repeated entries, or should it be based on the number of unique members in the ASIC_DB?
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@erohsik - could you please help address the comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new next hop group attribute to specify if a next hop group is programmed by repeating the next hop members in proportion to their weight or by using the intrinsic next hop group weight support in the hardware.