Skip to content

Conversation

@jjin62
Copy link

@jjin62 jjin62 commented Oct 9, 2025

  1. Add a new precision attribute flag for optical analog values (e.g., gain, tilt, power), instead of using double/float point type which would introduce NaN issue.
  2. Add support for optical attenuator in experimental extensions, derived from openconfig-optical-attenuator.yang.
  3. Add support for optical amplifier in experimental extensions, derived from openconfig-optical-amplifier.yang.

@jjin62
Copy link
Author

jjin62 commented Oct 9, 2025

  1. Introducing two new SAI objects OTN-OA and OTN-ATTENUATOR using SAI experimental extension mechanism. OA and ATTENUATOR are optical modules which can form a simplest optical amplifier.
  2. Gauged/Analog values (optical power, gain, attenuation etc..) are usually represented in a float point format (double or float). However, double/float data type is prohibited in SAI to avoid NaN issue (see meta/Makefile compile flag "-Wfloat-equal"). Therefore, a @precision tag is introduced to represent the number of digits after the decimal point. Any integer type with a @precision tag can be used to represent a decimal type.
    Ref SAI Support optical transport device - proposed by sonic-wg-otn #2216

@jjin62 jjin62 closed this Oct 9, 2025
@jjin62 jjin62 reopened this Oct 9, 2025
@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 2217 in repo opencomputeproject/SAI

1. Add a new precision attribute flag for optical analog values (e.g., gain, tilt, power), instead of using double/float point type which would introduce NaN issue.
2. Add support for optical attenuator in experimental extensions, derived from openconfig-optical-attenuator.yang.
3. Add support for optical amplifier in experimental extensions, derived from openconfig-optical-amplifier.yang.

Signed-off-by: Lu.Mao <lu.mao@molex.com>
@jjin62
Copy link
Author

jjin62 commented Nov 5, 2025

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 2217 in repo opencomputeproject/SAI

@jjin62
Copy link
Author

jjin62 commented Nov 5, 2025

/azp w run

@azure-pipelines
Copy link

Command 'w' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants