Implement an Async Chain, to enable async chain operations #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JS / TS didnt like the Abstract Class loop we had with the chaining setup."TypeError: Class extends value undefined is not a constructor or null "
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds async chain functionality to the collections module, introducing an AsyncChain class that provides asynchronous operations for collection processing. The PR also removes the previously existing mapValues method from the global object prototype extensions and exports the new async chain functionality.
- Introduces comprehensive async collection processing with
AsyncChainclass - Adds async variants of all existing chain operations (map, filter, reduce, etc.)
- Integrates async chains with the existing synchronous chain API
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| src/objects.ts | Removes mapValues method from global object prototype extensions |
| src/index.ts | Exports the new AsyncChain functionality |
| src/collections/AsyncChain.ts | Implements the complete async chain functionality with all collection operations |
| src/collections/AsyncChain.test.ts.md | Test snapshots for async chain functionality |
| src/collections/AsyncChain.test.ts | Comprehensive test suite for async chain operations |
| src/collections.ts | Integrates async chains with existing synchronous chains and updates type exports |
| src/collections.test.ts | Additional tests for async chain integration |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
reckter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Published PR as canary version:
3.0.0--canary.39.17122777697.0✨ Test out this PR locally via:
npm install @opencreek/ext@3.0.0--canary.39.17122777697.0 # or yarn add @opencreek/ext@3.0.0--canary.39.17122777697.0