-
Notifications
You must be signed in to change notification settings - Fork 3
Tweak messages if synthetic data #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@mccalluc if 'grouping' isn't appropriate for synthetic data, can the input in the Grouping card be disabled, when the user chooses synthetic data? |
It's still useful for generating synthetic data, because the string-valued columns can't be selected for analysis... Maybe that's what needs to be tackled first? But I don't want to make the code much more complicated for something that feels like a pretty minor UI feature. Not sure about the best course here: I'll give it more thought, but if you have suggestions, that's great, too. |
I'm not sure I understand your original comment - 'We don't really have "grouping" for synthetic data, but changing that based on the product type would get really annoying, and this might be fine with users.' |
|
What is now called "grouping" is still very useful for synthetic data, even if it's not actually grouping:
It wouldn't be impossible for these to change, but it would get messy. Right now an analysis plan can be used either for synthetic data or for stats, and the user can toggle between the two on the first tab, without invalidating anything on the second tab. For that reason, I think it makes sense to confine the search space to changes of wording, particular changes of wording just for synthetic data. When synthetic data is selected, instead of |
For reviewer: