Skip to content

Conversation

@mccalluc
Copy link
Contributor

@mccalluc mccalluc commented Jan 8, 2026

For reviewer:

  • Do the messages look good? We don't really have "grouping" for synthetic data, but changing that based on the product type would get really annoying, and this might be fine with users.
  • Any other places where the display should be conditional?

@github-project-automation github-project-automation bot moved this to Pending in DP Wizard Jan 8, 2026
@mccalluc mccalluc changed the title 681 synth data message tweak Tweak messages if synthetic data Jan 8, 2026
@mccalluc mccalluc moved this from Pending to Ready for Review in DP Wizard Jan 12, 2026
@mccalluc mccalluc mentioned this pull request Jan 12, 2026
@ekraffmiller ekraffmiller moved this from Ready for Review to In Review in DP Wizard Jan 14, 2026
@ekraffmiller ekraffmiller self-assigned this Jan 14, 2026
@ekraffmiller
Copy link
Member

@mccalluc if 'grouping' isn't appropriate for synthetic data, can the input in the Grouping card be disabled, when the user chooses synthetic data?

@mccalluc
Copy link
Contributor Author

can the input in the Grouping card be disabled, when the user chooses synthetic data?

It's still useful for generating synthetic data, because the string-valued columns can't be selected for analysis... Maybe that's what needs to be tackled first? But I don't want to make the code much more complicated for something that feels like a pretty minor UI feature.

Not sure about the best course here: I'll give it more thought, but if you have suggestions, that's great, too.

@ekraffmiller
Copy link
Member

can the input in the Grouping card be disabled, when the user chooses synthetic data?

It's still useful for generating synthetic data, because the string-valued columns can't be selected for analysis... Maybe that's what needs to be tackled first? But I don't want to make the code much more complicated for something that feels like a pretty minor UI feature.

Not sure about the best course here: I'll give it more thought, but if you have suggestions, that's great, too.

I'm not sure I understand your original comment - 'We don't really have "grouping" for synthetic data, but changing that based on the product type would get really annoying, and this might be fine with users.'

@mccalluc
Copy link
Contributor Author

mccalluc commented Jan 22, 2026

What is now called "grouping" is still very useful for synthetic data, even if it's not actually grouping:

  • Non-numeric fields aren't available for "columns"
  • Only "grouping" lets us specify known values

It wouldn't be impossible for these to change, but it would get messy. Right now an analysis plan can be used either for synthetic data or for stats, and the user can toggle between the two on the first tab, without invalidating anything on the second tab.

For that reason, I think it makes sense to confine the search space to changes of wording, particular changes of wording just for synthetic data.

When synthetic data is selected, instead of Columns / Grouping, would Numeric / Categorical do?
Or maybe Numeric Columns / Categorical Groups in either mode? (It would be nice to have names that work in either mode, so we don't need to make the display logic more complicated.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

"Select columns to calculate statistics on": Should be different for synth data

3 participants