Skip to content

html-escape user-provided text #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mccalluc wants to merge 2 commits into
base: main
Choose a base branch
from
Open

html-escape user-provided text #809

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4a4e7c
html escape user-provided text
mccalluc Jan 22, 2026
da95187
merge
mccalluc Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion dp_wizard/shiny/panels/results_panel/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import html
import json
import re
from pathlib import Path
Expand Down Expand Up @@ -369,7 +370,11 @@ def notebook_py():
return "raise Exception('qa_mode!')"
return NotebookGenerator(
analysis_plan(),
input.custom_download_note(),
# The custom download note is inserted as a comment,
# and jupytext copies it verbatim to a markdown cell,
# and nbconvert does not sanitize MD before converting to HTML.
# Sanitizing HTML would be more complicated, and potentially lossy.
html.escape(input.custom_download_note(), quote=False),
).make_py()

@reactive.calc
Expand Down
Loading