This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Open
Conversation
eddiestudies
reviewed
Apr 9, 2020
service/demo/DP_SQL_demo.ipynb
Outdated
| " from urllib.request import urlretrieve\n", | ||
| " urlretrieve(url, local_file)\n", | ||
| "\n", | ||
| "root_url = subprocess.check_output(\"git rev-parse --show-toplevel\".split(\" \")).decode(\"utf-8\").strip()\n", |
Contributor
There was a problem hiding this comment.
We should remove this, it should no longer be needed. You can make root_url -> "." The current directory
added 2 commits
April 9, 2020 14:07
joshua-oss
reviewed
Apr 9, 2020
Contributor
joshua-oss
left a comment
joshua-oss
left a comment
There was a problem hiding this comment.
Looks great; awesome to have the flag to control behavior!
I would also recommend showing len(result) and len(korolova_result), since those will be the count of distinct ngrams. That will be a good comparison with the statement earlier where you show len(exact), and should show the difference between the two methods even more clearly than the sum(n). The difference should be more pronounced as max_contrib gets larger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.