Update vegetation parameters in constants.py #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes unused V_Lat parameter solves #120 Changes default for veg_min_elevation to -10 to avoid unwanted use of this functionality.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates vegetation parameters in the constants file by removing an unused lateral growth parameter and adjusting the minimum elevation threshold for vegetation growth. The changes aim to solve issue #120 by preventing unintended activation of the minimum elevation restriction.
- Removed the unused
V_lat(lateral growth) parameter from vegetation constants - Changed
veg_min_elevationdefault from 3 to -10 meters to avoid unwanted filtering
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sierd
added a commit
that referenced
this pull request
Nov 3, 2025
* fixed dependencies for python 3.13 (#236) * test with timing function * Add devcontainer for use in codespaces (#240) * devcontainer added * Update Dockerfile * Update Dockerfile * Update devcontainer.json * Update Dockerfile * fixed dependencies for python 3.13 (#236) (#239) * Update Dockerfile * remove abundant stuff * Add devcontainer for use in codespaces (#240) (#242) * devcontainer added * Update Dockerfile * Update Dockerfile * Update devcontainer.json * Update Dockerfile * fixed dependencies for python 3.13 (#236) (#239) * Update Dockerfile * remove abundant stuff * Update Dockerfile (#243) This patch updates the dockerfile for the codespace to be compatible with developer mode. You need to manual install python in dev model after the docker is created. * Cleanup main (#245) * delete abundant files * deleted: aeolis/examples/vanWesten2024/blowout/figure_grid_initialization.png deleted: aeolis/examples/vanWesten2024/blowout/figure_params_initialization.png deleted: aeolis/examples/vanWesten2024/blowout/figure_timeseries_initialization.png * Update pyproject.toml * Update README.md * Update CITATION.cff * Update release info (#246) * Update pyproject.toml * Update CITATION.cff * Update README.md * Update Python version and dependencies in installation guide * Implement error message for missing ne_file Added error handling for missing 'ne_file' when using Avalanching. * Print message for aeolis installation in Dockerfile Add message indicating manual installation of aeolis * Update vegetation parameters in constants.py (#250) * Update vegetation parameters in constants.py Removes unused V_Lat parameter solves #120 Changes default for veg_min_elevation to -10 to avoid unwanted use of this functionality. * Update aeolis/constants.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sierd
added a commit
that referenced
this pull request
Nov 6, 2025
* Initialisation of the GUI Including some overdue maintenance related to python 2-->3 in the write_configfile script. * Updated GUI structure using Class * updated gui * update gui branche with latest main (#255) * fixed dependencies for python 3.13 (#236) * test with timing function * Add devcontainer for use in codespaces (#240) * devcontainer added * Update Dockerfile * Update Dockerfile * Update devcontainer.json * Update Dockerfile * fixed dependencies for python 3.13 (#236) (#239) * Update Dockerfile * remove abundant stuff * Add devcontainer for use in codespaces (#240) (#242) * devcontainer added * Update Dockerfile * Update Dockerfile * Update devcontainer.json * Update Dockerfile * fixed dependencies for python 3.13 (#236) (#239) * Update Dockerfile * remove abundant stuff * Update Dockerfile (#243) This patch updates the dockerfile for the codespace to be compatible with developer mode. You need to manual install python in dev model after the docker is created. * Cleanup main (#245) * delete abundant files * deleted: aeolis/examples/vanWesten2024/blowout/figure_grid_initialization.png deleted: aeolis/examples/vanWesten2024/blowout/figure_params_initialization.png deleted: aeolis/examples/vanWesten2024/blowout/figure_timeseries_initialization.png * Update pyproject.toml * Update README.md * Update CITATION.cff * Update release info (#246) * Update pyproject.toml * Update CITATION.cff * Update README.md * Update Python version and dependencies in installation guide * Implement error message for missing ne_file Added error handling for missing 'ne_file' when using Avalanching. * Print message for aeolis installation in Dockerfile Add message indicating manual installation of aeolis * Update vegetation parameters in constants.py (#250) * Update vegetation parameters in constants.py Removes unused V_Lat parameter solves #120 Changes default for veg_min_elevation to -10 to avoid unwanted use of this functionality. * Update aeolis/constants.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * input and output tab added improved domain plotting functionality * added functionality * Fix GUI crash when canceling file selection on startup (#256) * Initial plan * Fix GUI to handle cancel on startup gracefully Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Address code review feedback: move import to top and remove hardcoded path Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Remove placeholder path, set configfile to 'No file selected' when canceled Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Add Plot Output 1D tab for transect visualization with unified interface (#257) * Initial plan * Add Plot Output 1D tab with transect plotting functionality Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Add variable change callback for 1D plot updates Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Fix code review issues: cross-platform paths and dimension validation Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Improve dimension validation and dictionary access robustness Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Fix transect direction bug and unify 2D/1D tab interface with dynamic variable dropdowns Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * bugfixes (#259) * Initial plan * Add Plot Output 1D tab with transect plotting functionality Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Add variable change callback for 1D plot updates Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Fix code review issues: cross-platform paths and dimension validation Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Improve dimension validation and dictionary access robustness Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Fix transect direction bug and unify 2D/1D tab interface with dynamic variable dropdowns Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * bugfixes * added functionality, colorbars, many small fixes. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * domain overview added to 1D plot mode. * Delete aeolis/GUI.ipynb * Remove incompatible parameter checks for ne_file Removed error handling for missing ne_file when using Avalanching. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com>
Merged
Sierd
added a commit
that referenced
this pull request
Nov 6, 2025
* Initialisation of the GUI Including some overdue maintenance related to python 2-->3 in the write_configfile script. * Updated GUI structure using Class * updated gui * update gui branche with latest main (#255) * fixed dependencies for python 3.13 (#236) * test with timing function * Add devcontainer for use in codespaces (#240) * devcontainer added * Update Dockerfile * Update Dockerfile * Update devcontainer.json * Update Dockerfile * fixed dependencies for python 3.13 (#236) (#239) * Update Dockerfile * remove abundant stuff * Add devcontainer for use in codespaces (#240) (#242) * devcontainer added * Update Dockerfile * Update Dockerfile * Update devcontainer.json * Update Dockerfile * fixed dependencies for python 3.13 (#236) (#239) * Update Dockerfile * remove abundant stuff * Update Dockerfile (#243) This patch updates the dockerfile for the codespace to be compatible with developer mode. You need to manual install python in dev model after the docker is created. * Cleanup main (#245) * delete abundant files * deleted: aeolis/examples/vanWesten2024/blowout/figure_grid_initialization.png deleted: aeolis/examples/vanWesten2024/blowout/figure_params_initialization.png deleted: aeolis/examples/vanWesten2024/blowout/figure_timeseries_initialization.png * Update pyproject.toml * Update README.md * Update CITATION.cff * Update release info (#246) * Update pyproject.toml * Update CITATION.cff * Update README.md * Update Python version and dependencies in installation guide * Implement error message for missing ne_file Added error handling for missing 'ne_file' when using Avalanching. * Print message for aeolis installation in Dockerfile Add message indicating manual installation of aeolis * Update vegetation parameters in constants.py (#250) * Update vegetation parameters in constants.py Removes unused V_Lat parameter solves #120 Changes default for veg_min_elevation to -10 to avoid unwanted use of this functionality. * Update aeolis/constants.py --------- --------- * input and output tab added improved domain plotting functionality * added functionality * Fix GUI crash when canceling file selection on startup (#256) * Initial plan * Fix GUI to handle cancel on startup gracefully * Address code review feedback: move import to top and remove hardcoded path * Remove placeholder path, set configfile to 'No file selected' when canceled --------- * Add Plot Output 1D tab for transect visualization with unified interface (#257) * Initial plan * Add Plot Output 1D tab with transect plotting functionality * Add variable change callback for 1D plot updates * Fix code review issues: cross-platform paths and dimension validation * Improve dimension validation and dictionary access robustness * Fix transect direction bug and unify 2D/1D tab interface with dynamic variable dropdowns --------- * bugfixes (#259) * Initial plan * Add Plot Output 1D tab with transect plotting functionality * Add variable change callback for 1D plot updates * Fix code review issues: cross-platform paths and dimension validation * Improve dimension validation and dictionary access robustness * Fix transect direction bug and unify 2D/1D tab interface with dynamic variable dropdowns * bugfixes * added functionality, colorbars, many small fixes. --------- * domain overview added to 1D plot mode. * Delete aeolis/GUI.ipynb * Remove incompatible parameter checks for ne_file Removed error handling for missing ne_file when using Avalanching. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unused V_Lat parameter
solves #120
Changes default for veg_min_elevation to -10 to avoid unwanted use of this functionality.