feat(build): migrate to ecc-tools wheel, re-enable ci#57
Merged
Conversation
97a7d66 to
22735e7
Compare
31326ef to
332b797
Compare
Signed-off-by: Emin <me@emin.chat>
Signed-off-by: Emin <me@emin.chat>
…sion When ecc-dreamplace is a bazel_dep via local_path_override, both modules declaring hub_name = "pypi" causes rules_python to reject the duplicate. Prefix both hubs with their repo name. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…m source Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Emin <me@emin.chat>
Signed-off-by: Emin <me@emin.chat>
Signed-off-by: Emin <me@emin.chat>
Signed-off-by: Emin <me@emin.chat>
Signed-off-by: Emin <me@emin.chat>
…urces Switch from `pip install --no-deps` to `uv pip install` so that the smoke test respects [tool.uv.sources] URLs for ecc-dreamplace and ecc-tools, which are not on PyPI. Also restores the ECCToolsModule import assertion removed in the --no-deps workaround. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace --target with a temp venv so uv pip install runs in project mode and correctly reads pyproject.toml / tool.uv.sources to resolve ecc-dreamplace and ecc-tools from GitHub URLs instead of PyPI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Hermetic Python lacks ensurepip, so `python -m venv` fails. Use `uv venv --python` instead, which does not depend on ensurepip. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
uv pip install does not read tool.uv.sources from pyproject.toml. Instead, explicitly pass the ecc-tools and ecc-dreamplace wheel URLs from GitHub Releases so all deps are resolvable during smoke test. Also switches from pip to uv pip install for consistency. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Emin <me@emin.chat>
332b797 to
9ea2b7d
Compare
Member
Author
|
Should re-enable format ci after #7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous CI built the entire ECOS Studio desktop application (Tauri GUI, AppImage, deb packages) inside the ECC repo. Since the GUI and API server have been moved to
ecos/gui/andecos/server/respectively, the ECC repo should focus on what it owns: the RTL-to-GDS Python toolchain and its distributable wheel.After migrating the build of ecc-tools to its own repository, the time required for both release builds and CI builds will be significantly reduced (we only need to build a pure Python wheel now).