fix: Use correct elasticsearch field name for .raw field facet filtering#4665
Open
Waleed-Mujahid wants to merge 1 commit intoopenedx:masterfrom
Open
fix: Use correct elasticsearch field name for .raw field facet filtering#4665Waleed-Mujahid wants to merge 1 commit intoopenedx:masterfrom
Waleed-Mujahid wants to merge 1 commit intoopenedx:masterfrom
Conversation
Author
|
@DawoudSheraz Hey can you run test this PR on your end? |
Contributor
I am not a committer or contributor of course-discovery anymore. Tagging @openedx/committers-course-discovery here |
muhammadali286
approved these changes
Sep 15, 2025
UsamaSadiq
approved these changes
Sep 15, 2025
Member
|
Approved. |
When filtering by facets that use .raw fields (like language.raw), the filter_by_facets method was incorrectly using the facet configuration key instead of the actual elasticsearch field name, causing filters to fail for case-sensitive .raw fields.
Waleed-Mujahid
force-pushed
the
waleed/fix-raw-fields-facets
branch
from
6d351d8 to
bea73d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The incorrect field name caused
elasticsearchto query the analyzed'language' field instead of the case-sensitive 'language.raw' keyword
field, resulting in no matches for capitalized values.
Solution
Modified FacetedFieldSearchFilterBackend.filter_by_facets() to use
the configured elasticsearch field name from field_facets[field]['field']
instead of the facet key when building elasticsearch term queries.
Testing
This fix ensures that URLs like:
/api/v1/search/course_runs/facets/?selected_facets=language_exact:Englishnow correctly filter results using the language.raw field instead of
failing due to case sensitivity mismatches.