feat: adding weeks to complete filed into Algolia facet#4677
Open
nbalne wants to merge 1 commit intoopenedx:masterfrom
Open
feat: adding weeks to complete filed into Algolia facet#4677nbalne wants to merge 1 commit intoopenedx:masterfrom
nbalne wants to merge 1 commit intoopenedx:masterfrom
Conversation
nbalne
force-pushed
the
PROD-4428-Alogolia_Index
branch
14 times, most recently
from
3d302bf to
3c24d90
Compare
|
@nbalne rebase your branch with |
nbalne
force-pushed
the
PROD-4428-Alogolia_Index
branch
from
3c24d90 to
d41f699
Compare
nbalne
force-pushed
the
PROD-4428-Alogolia_Index
branch
5 times, most recently
from
2f59374 to
b53559a
Compare
nbalne
force-pushed
the
PROD-4428-Alogolia_Index
branch
4 times, most recently
from
a26b1d0 to
95ea6f2
Compare
nbalne
force-pushed
the
PROD-4428-Alogolia_Index
branch
from
95ea6f2 to
e0ffe20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket : https://2u-internal.atlassian.net/browse/PROD-4428
Implemented AlgoliaProxyCourseFactory with optional course runs.
Added post-generation logic in factories to create an advertised_course_run when needed.
Introduced product_weeks_to_complete property to safely return weeks_to_complete from the associated run.
Added unit tests for AlgoliaProxyCourse to verify correct handling of:
Courses with valid weeks_to_complete values.
Courses with no runs.
Courses explicitly created without runs.