fix: video_config runtime service added when loading for xBlock

[marslanabdulrauf]

Related Ticket

https://github.com/mitodl/hq/issues/9905 (MIT Internal)

Description

Thanks @farhan for helping me out in understanding the new changing around VideoXblock and this issue 👍

This pull request introduces the VideoConfigService into the Studio runtime service loader, making video configuration functionality available throughout the Studio application. The main change is the addition of this service to the set of services loaded for Studio.

Service integration:

• Imported VideoConfigService from openedx.core.djangoapps.video_config.services in cms/djangoapps/contentstore/utils.py.
• Added video_config entry to the services dictionary in the load_services_for_studio function, enabling access to video configuration features in Studio.

Testing instructions

1. Create a new Course or use an existing one
2. Add video Xblock and try to upload transcript(any language)
3. In master branch -- there will be an error (Response: Runtime does not support transcripts.)
4. Deleting the transcript results in same error
5. Checkout to this branch
6. Upload/delete transcript -- It should work fine

[openedx-webhooks]

Thanks for the pull request, @marslanabdulrauf!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[farhan]

Welcome @marslanabdulrauf

Sharing the previous PR's related to this issue for the context:
#37793
#37657

Task on my side:

1. Is there any change after the PR's merging that caused the issue?
2. If no, why were they working before while doing the testing in the above PR's?

[kdmccormick]

merged with message:

Adding transcripts to Videos now goes through the new VideoConfigService
instead of direct calls from the VideoBlock. However, the VideoConfigService
was not added to Studio. This patch fixes transcript uploading by adding
the service to Studio.

[farhan]

@marslanabdulrauf

Here are my testing notes (testing done on my local machine setup of tutor-dev)

1. Transcripts are uploading/deleting on PR
2. Transcripts are not uploading/deleting on master branch
3. Transcripts are uploading/deleting on this PR [Testing of this PR]
4. Transcripts are uploading/deleting on master branch with revert commit of PR, command is given below

git revert 7e72ec2778eaf7177a797d600f2383f4554eb003

The following PR is likely the origin of this issue:
#37825

[kdmccormick]

Thanks @marslanabdulrauf . Do you mind backporting to ulmo?

Ah I see @farhan , then it seems like there was an interaction between the way we added the new VideoConfigService, and the recent fix which copies the services dict so that it is not modified across threads. It would good to be figure out what went wrong, I wonder if this impacts any other services too.

[farhan]

I wonder if this impacts any other services too.

Yes, that needs to be figured out

[kdmccormick]

Thanks for noticing the connection @farhan . Would you be able to look into that next week?

[farhan]

Thanks for noticing the connection @farhan . Would you be able to look into that next week?

Sure, let's look into it next week

[kdmccormick]

Thanks!

The following PR is likely the origin of this issue: #37825

Making a copy of the services dict is a critical fix, so any adjustment we make will have to work around it rather than revert it.

[marslanabdulrauf]

Thanks @marslanabdulrauf . Do you mind backporting to ulmo?

Backport PR is created: #37902

@kdmccormick

[kdmccormick]

Ah, maybe this doesn't affect Ulmo?

[marslanabdulrauf]

Ah, maybe this doesn't affect Ulmo?

I created branch from Ulmo.1, could that be the reason of those test failures ?

[kdmccormick]

Nope, it was my mistake to ask for a backport. The video config service wasn't added until after the Ulmo cutoff, so the backport does not make sense. I've confirmed using an ulmo.1 instance that the bug fixed here isn't present in Ulmo. Thanks!