-
Notifications
You must be signed in to change notification settings - Fork 4.2k
docs: add reader context to settings simplification decision #37903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Added toggle documentation for HOMEPAGE_COURSE_MAX.
|
Thanks for the pull request, @Ozohu1! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Thanks for the guidance! This is a documentation-only change intended to improve clarity for readers of the existing decision record. No behavioural or configuration changes are introduced. Happy to make any wording adjustments if helpful. |
Hi. A quick one! Do i need to sign a new CLA for every contribution made by me? Please let me know. thanks |
Hi @Ozohu1! You only need to fill out a CLA one time, and then you can contribute as much as you'd like. |
|
@Ozohu1 the checks have been enabled on this pull request, but it looks like a few of them are failing. Would you mind taking a look? |
Description
Added a short “Context for Readers” section to
docs/decisions/0022-settings-simplification.rstto clarify the intended audience and scope of the decision document.This improves readability and reduces onboarding friction for contributors and operators encountering this proposal for the first time.
Closes: #36215