Skip to content

Conversation

@papphelix
Copy link

This pull request is to fix the file param in URL which is creating security issue by sending arbitrary data in query param which can put cms under risk of different attacks like

  • random load which is read
  • xss attack if pdf.js is not handling properly while reading file param

Issue Screenshots:
image

image

Fixes done:

  • Removed File param from iframe src
  • Added postmessage based communication to pass on file path for loading the PDF on the pdf.js
  • When the url of iframe is opened it will always show chapters first pdf by default.
pdf-file-param-removal.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants