Skip to content

Fixes for several questions in the quizzes#67

Merged
sarina merged 1 commit intoopenedx:mainfrom
AntonOfTheWoods:fixen
Oct 22, 2025
Merged

Fixes for several questions in the quizzes#67
sarina merged 1 commit intoopenedx:mainfrom
AntonOfTheWoods:fixen

Conversation

@AntonOfTheWoods
Copy link
Contributor

Some of the questions appear to have errors in them. Separated into 3 commits so each can be evaluated separately

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 20, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @AntonOfTheWoods!

This repository is currently maintained by @sarina.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Oct 20, 2025
@AntonOfTheWoods AntonOfTheWoods changed the title Fixes for several questions in the quizes Fixes for several questions in the quizzes Oct 20, 2025
@sarina
Copy link
Contributor

sarina commented Oct 20, 2025

This looks good. However, you'll also need to regenerate the XML (see https://github.com/openedx/training-courses?tab=readme-ov-file#contributing) for that test to pass. You also need to use conventional commits.

@sarina sarina moved this from Needs Triage to Ready for Review in Contributions Oct 20, 2025
@sarina sarina moved this from Ready for Review to Waiting on Author in Contributions Oct 20, 2025
@AntonOfTheWoods
Copy link
Contributor Author

Ok, so going back it does look like I skipped that chapter :-D. I squashed the commits and added a fix:. From my reading of this, footers are ok, right?

@sarina
Copy link
Contributor

sarina commented Oct 21, 2025

Yep, footers work!

Copy link
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, so, the tests didn't fail but also you didn't touch the other two courses so I'm not sure why there are changes to those .tar.gz files ,could you remove those?

- incorrect answer to tutor plugin question
- bad question about updating master branch
- Paragon is NOT and advantage of Paragon

Signed-off-by: Anton Melser <anton.melser@outlook.com>
@AntonOfTheWoods
Copy link
Contributor Author

@sarina removed.

@sarina sarina merged commit 3fe753d into openedx:main Oct 22, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Oct 22, 2025
@sarina
Copy link
Contributor

sarina commented Oct 22, 2025

Thanks! I'll update the course with the new solutions later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants