Fixes for several questions in the quizzes#67
Conversation
|
Thanks for the pull request, @AntonOfTheWoods! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
This looks good. However, you'll also need to regenerate the XML (see https://github.com/openedx/training-courses?tab=readme-ov-file#contributing) for that test to pass. You also need to use conventional commits. |
97c34b6 to
1c22618
Compare
|
Ok, so going back it does look like I skipped that chapter :-D. I squashed the commits and added a |
|
Yep, footers work! |
sarina
left a comment
There was a problem hiding this comment.
Hmm, so, the tests didn't fail but also you didn't touch the other two courses so I'm not sure why there are changes to those .tar.gz files ,could you remove those?
- incorrect answer to tutor plugin question - bad question about updating master branch - Paragon is NOT and advantage of Paragon Signed-off-by: Anton Melser <anton.melser@outlook.com>
1c22618 to
288c98b
Compare
|
@sarina removed. |
|
Thanks! I'll update the course with the new solutions later today. |
Some of the questions appear to have errors in them. Separated into 3 commits so each can be evaluated separately